[Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222

--- Comment #33 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
Katrin,

(In reply to comment #32)
> (kohafield IS NULL OR kohafield = '') means the data is saved to
> more_subfields_xml.

I disagree with failing the patch because of the mapping update. It very
carefully makes sure not to clobber any existing mappings. The only case where
an existing mapping might be clobbered is if someone has manually created an
items.nonpublicnote column and mapped something other than 952$x to it. If
someone already has non-public notes in their item records, adding the mapping
will not make it any more inaccessible than it already is.

To restate the following SQL in English:
  UPDATE marc_subfield_structure SET kohafield='items.nonpublicnote' WHERE
  (kohafield IS NULL OR kohafield = '') AND tagfield='952' AND tagsubfield='x'

"Map 952$x to items.nonpublicnote if and only if 952$x is not mapped to
anything else."

The updatedatabase is MARC21/NORMARC-specific, though, and doesn't check that
the flavour is MARC21 or NORMARC before updating. I will add a follow-up
adjusting it to check the marcflavour, and also not remap items.nonpublicnote
if it has already been mapped to a field.

I think it's much better to have non-public notes accessible in some cases than
none, which is our current situation. I can already edit non-public item notes.

Also, it's worth noting that if someone has changed their mappings for the 952
field, they will have had to redo the Zebra configuration files, so they
clearly know what they are doing.

-- 
You are receiving this mail because:
You are watching all bug changes.