[Koha-bugs] [Bug 5342] Serial claiming improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Found a small problem in the database update:

1) Database update
kohastructure:
`claimdate` date default NULL,
+  claims_count int(11) default 0,
   `routingnotes` text,

updatedatabase:
+if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
+    $dbh->do("ALTER TABLE serial ADD COLUMN claims_count INT(11) DEFAULT 0");
+    print "Upgrade to $DBversion done (Add claims_count field in serial
table)\n";
+    SetVersion($DBversion);
+}
+

So the result will be a slightly different sequence of fields in the tables. I
think would be better to make it the same to avoid confusion and possible
problems.

2) Dates could be displayed using the TT Dates plugin

3) It would be nice if dates in the email could be formatted according to
dateformat system preference (order date for example). Currently shows as:
2012-02-01

4) It would be good to update the sample notice to have the new syntax so
people know how to use it. (like we did for 5347)

5) Commit message tells to use <order> tags, but when I do, it does not get
replaced:

Template:
<order>
<<biblio.title>>
<<biblio.author>>
<<biblio.serial>>
<<serial.serialid>>
<<serial.subscriptionid>>
<<serial.biblionumber>>
<<serial.planneddate>>
<<serial.routingnotes>>
<<serial.claimdate>>
<<serial.serialseq>>
</order>

Generated email:
<order>
Quellensammlung zur Kulturgeschichte


24
8
12
2012-05-01

2012-04-10
Vol 2011, Issue 55
Quellensammlung zur Kulturgeschichte


25
8
12
2012-06-01

2012-04-10
Vol 2011, Issue 56
</order>

Failing QA mainly for 1 and 5. Sorry :(

-- 
You are receiving this mail because:
You are watching all bug changes.