[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9536|0                           |1
        is obsolete|                            |
             Status|Failed QA                   |Needs Signoff
           Assignee|gmcharlt at gmail.com          |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 10192
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10192&action=edit
Proposed Amended Patch

Patch rebased against master. Have added sanitizing of order and limit
parameters (although order is currently always passed a constant string from
the caller)

Note on issue 2 adding parens around the variable forces the tt parser to
evaluate as an expression. i.e. potentially adding processing where a simple
variable is used. While it was used defensively in converting templates I'd
suggest following normal tt style in new code

-- 
You are receiving this mail because:
You are watching all bug changes.