[Koha-bugs] [Bug 6175] Mismatch between marc_subfield_structure and authorised_values tables

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6175

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment: This patch has some problems:
  * it introduces a constraint that is wrong:
+  CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authorised_value`)
REFERENCES `authorised_values` (`category`) ON DELETE CASCADE ON UPDATE CASCADE
 => the constraint can be on authorised_values, but also on branches or
itemtype, so a SQL constraint is unapplicable here
  * it contains a lot of changes in french file that are just moving things
from the bottom to the top of file without reason (at least without relation to
this patch. As the patch has been made by someone from argentina, I think it
was not intended to update french files !)
  * there is no updatedatabase part on this patch making existing Koha being
de-synchronised from freshly installed Koha

for those reasons, failed QA, sorry

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.