[Koha-bugs] [Bug 6175] Mismatch between marc_subfield_structure and authorised_values tables

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6175

--- Comment #6 from MJ Ray (software.coop) <mjr at software.coop> ---
(In reply to comment #5)
> QA comment: This patch has some problems:
>   * it introduces a constraint that is wrong:
> +  CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY
> (`authorised_value`) REFERENCES `authorised_values` (`category`) ON DELETE
> CASCADE ON UPDATE CASCADE
>  => the constraint can be on authorised_values, but also on branches or
> itemtype, so a SQL constraint is unapplicable here

So is this potential mismatch unavoidable with the current database design?

>  * it contains a lot of changes in french file that are just moving things from 
> the bottom to the top of file without reason (at least without relation to this 
> patch. As the patch has been made by someone from argentina, I think it was not > intended to update french files !)
>   * there is no updatedatabase part on this patch making existing Koha being
> de-synchronised from freshly installed Koha

These are not currently among the
http://wiki.koha-community.org/wiki/Coding_Guidelines#Database but perhaps they
should be?

This would not be the first patch to change kohastructure.sql without a
matching updatedatabase, after all... but I remember them because they caused
bugs, so maybe it should be a guideline.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.