[Koha-bugs] [Bug 7167] updatedatabase improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #66 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #65)
> (In reply to comment #64)
> > > If I recall correctly, you could switch modes via $ENV{DEBUG} in koha-httpd,
> > > but it only seems now to hide the Execute button in normal mode. Am I
> > > correct?
> > > Wasn't it meant to enable/disable linear vs non-linear updates?
> > ??? I don't understand what you mean here.
> If you set DEBUG=1, what is the difference? Seems to me only hiding the
> Execute button. I see that it indeed prevents non-linear updating. Question
> solved more or less; will come back to it in QA.
OK, got it !

The idea behind this was that, in production environment, there is no reason
not to apply all patches. So if DEBUG=0, having only the option to apply all
update sounds OK.
If DEBUG=1, a *developer* can find some reason not to apply everything.

> > Can you explain what you made ? I suspect you have added a test SQL in
> > installer/data/mysql/versions/ and called it test01.sql. It's wrong, it must
> > be a number 3.09.00.014 for example (could also be 123.456, but it must be
> > numbers+. only)
> Yes, I made that file. Instead of such an error message, I would propose
> just to ignore files that do not match the numbering scheme. Perhaps mark
> them as inappropriate on the new updatedatabase form, or so. (In a folder
> you can always expect files with other names..) Will return to that too soon.
If someone submit a patch including a file with a wrong name it won't pass QA,
that's as simple as that, I'm not sure it's needed to check for the format.

Also note that, when the patch will be pushed, i'll start a wiki page where
ppl, when submitting a patch with a DB update, will be able to mark/reserve a
number to avoid having a conflict. And if a number does not make his way into
Koha finally, that's not a big problem, we can let the number empty or create a
fake DB update

-- 
You are receiving this mail because:
You are watching all bug changes.