[Koha-bugs] [Bug 7167] updatedatabase improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #67 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
> > > Can you explain what you made ? I suspect you have added a test SQL in
> > > installer/data/mysql/versions/ and called it test01.sql. It's wrong, it must
> > > be a number 3.09.00.014 for example (could also be 123.456, but it must be
> > > numbers+. only)
> > Yes, I made that file. Instead of such an error message, I would propose
> > just to ignore files that do not match the numbering scheme. Perhaps mark
> > them as inappropriate on the new updatedatabase form, or so. (In a folder
> > you can always expect files with other names..) Will return to that too soon.
> If someone submit a patch including a file with a wrong name it won't pass
> QA, that's as simple as that, I'm not sure it's needed to check for the
> format.

I think it would be best to catch that error and inform the user there is an
incorrectly named file. The goal is to lower the barrier to entry for
developers, and if a developer doesn't understand the correct naming scheme,
they should get useful feedback ("a file with an invalid name was provided")
instead of a scary error.

> Also note that, when the patch will be pushed, i'll start a wiki page where
> ppl, when submitting a patch with a DB update, will be able to mark/reserve
> a number to avoid having a conflict. And if a number does not make his way
> into Koha finally, that's not a big problem, we can let the number empty or
> create a fake DB update

-- 
You are receiving this mail because:
You are watching all bug changes.