[Koha-bugs] [Bug 8202] Add authorities to export tool

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comments:

Hi Jared,

Your modifications seem good and they are close to mine (for export.pl).
About your patch, I think you can repropose it modifying the indentation of
export.tt (ex. 
+        <ol><li>

+        </li></ol>

+[% ELSE %]

+<div id="exporttype" class="toptabs">
+<ul>
)

I agree with you, I quibble...

However, more important, I found a bug in this script while testing.
I can't exclude from export some fields, as 500$3 for example. The regexp to
split field and subfield is /^(\d*)(\w)?$/;
This is not what we want.

And, the subfield's deletion:
if( $subfield ) {
     $record->field($field)->delete_subfields($subfield);
}
only delete in the first field.

-- 
You are receiving this mail because:
You are watching all bug changes.