[Koha-bugs] [Bug 5339] Parcel closing in acq

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jun 25 07:45:53 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |mtj at kohaaloha.com

--- Comment #56 from Mason James <mtj at kohaaloha.com> ---
QA comments

1) parcel.tt and parcels.tt appear to have existing code globally reformatted
with pretty-formatting/auto-indentation

2) patch does not apply to current master
'19d30206df473ff6d801f15063f6837225b004bf' with some big conflicts 
(nor does it apply to master at the date of the last rebased patch?
'2012-06-10')

please resubmit patch without applying global pretty-formatting to existing
template code

failing QA on issue 1

otherwise… it looks good. both 'prove xt' and 'perlcritic' pass ok

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list