[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #100 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #88)
> Created attachment 10485 [details]
> Bug 6679 - fix 19 perlcritic violations from C4::Letters.pm


FAILED QA for this patch, I think the following lines don't have to be
modified:
-    return unless exists $params->{'letter'};
-    return unless exists $params->{'borrowernumber'};
-    return unless exists $params->{'message_transport_type'};
+    return exists $params->{'letter'};
+    return exists $params->{'borrowernumber'};
+    return exists $params->{'message_transport_type'};

It's unless, not undef :-)

-- 
You are receiving this mail because:
You are watching all bug changes.