[Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #8)
> Nope d, in fact caching that one won't win us much at all it's fast to
> render anyway. But looking into caching things that require computation,
> would be good. This patch is just to enable people to cache includes when
> they find ones, or even better create includes and cache them.

mmm... I'm not sure this patch should be pushed as is : if it's a good idea,
the 
-[% INCLUDE 'doc-head-open.inc' %]
+[% USE cache = Cache %]
+[% cache.inc(
+    'template' => 'doc-head-open.inc',
+    'keys' => {'dochead' => 'dochead'},
+    'ttl' => 360
+    )
+%]
is useless, so should be removed, and a more useful example used ?

QA comment: isn't 
{'cache_servers' => C4::Context->config('memcached_servers') }

as memcache is the default server for Koha::Cache ?

marking failed QA for now

-- 
You are receiving this mail because:
You are watching all bug changes.