[Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Jonathan,
You are probably right about this code in practice. But theoretically, if
ordernumber is empty, you may have more than one result.
In one of the templates below the ordernumber comes from parsing some text.
What if this fails somehow?
And how about a user removing the ordernumber from the URL in the browser?

Was the original idea of this script: If we have one, receive it rightaway. If
we have more, let the user choose (one more click to receive)? And just
thinking: why not receive more items at once if the date is the same and the
quantity is most often 1 ? Also keep in mind that not everybody creates the
items at the same time (AcqCreateItem pref).

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt

If we follow your approach here, I think we must add some check around
ordernumber and results, and change a few lines of documentation in the code
conveying the original idea of multiple results.

Changing status for need of clarification.

-- 
You are receiving this mail because:
You are watching all bug changes.