[Koha-bugs] [Bug 6557] biblioitems.totalissues unused

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

--- Comment #27 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to comment #26)
> (In reply to comment #24)
> > The FAUSP (Fighters Against Useless SysPrefs) commitee
> I recently saw this patch removing a pref :-)
> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263
> 
> (In reply to comment #25)
> > Although I consider the performance hit to be significant
> Could you make this more concrete? Did you test the difference in
> performance? Instead of just mentioning some milliseconds on a specific
> server, could we come to a reasonably accurate percentage or so? 
> If the performance increase would be below say 10%, we may not need two
> ways. But we probably do if we reach 50%?

As I recall, the performance hit was around 30%. Reducing the performance hit
at the cost of clean code separation is -- as I discussed with Ian -- not a
good idea, because it would make maintenance a nightmare, and move us one step
closer to C4::Search levels of mess. I would say that the syspref would be a
candidate for future removal, once DOM has entirely replaced GRS-1 (can we hope
this will be true for 3.14? Well, maybe 3.16), but I am not comfortable with
adding a feature that legacy libraries will be unable to take advantage of
(instant popularity updates).

-- 
You are receiving this mail because:
You are watching all bug changes.