[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> 2012-03-01 07:05:20 UTC ---
Hi Chris H.,

I was looking at your patch and I am a bit worried about the logic of the
configuration options. 
The patron category now has a pull down with 3 settings: block, don't block,
use syspref. And the system preference is block or don't block. 

When I am in the system preference editor, I have no way to find out, if my
patron categories are affected by my changes. And when I am looking at patron
categories I don't know what 'use syspref' will do. This seems confusing to me.
Perhaps we could do it the other way around matching the behaviour of
enhancedmessaging a bit?

System preference: Block, Don't block, Configure on category type level
Settings on patron category only show up when system preference is set to allow
configuraton on category tyle level.

For testing I fixed 2 small conflicts in your patch, be careful to keep the
check on existence of dateexpiry when you rebase your patch. This was a recent
change. Also the version number in updatedatabase should be XXX - this will
make it easier for RM and is easier to test. With XXX you only have to update
the kohaversion to the next higher number and the database update will happen.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.