[Koha-bugs] [Bug 7001] User Configurable Slips

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

Ian Walls <koha.sekjal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #86 from Ian Walls <koha.sekjal at gmail.com> ---
Another nit-picky detail:

The copyright statement and introductory POD for members/printslip.pl are
copied straight out of members/moremember.pl, and should be cleaned up to
reflect both the correct copyright, and the actual purpose of this particular
page.


And another:

Also, the checkbox for is_html in the letters.tt is not properly attributed. 
It's

<input type="checkbox" id="is_html" name="is_html" value="1" checked />

instead of 

<input type="checkbox" id="is_html" name="is_html" value="1" checked="checked"
/>


And a call for documentation for the <checkedout> and <reserves> tags and how
to use them.


Okay, so I think this is pretty solid stuff, the minor issues I've found
notwithstanding.  I would highly recommend we get some followup patches to deal
with what I've found, but I don't think any of them are significant enough to
warrant block QA.  The advantages imparted by the consolidation and cleanup to
the Letters code are very, very good, and if we do find bugs down the line
(which is always a risk with any code), it'll be easier to trace them and fix
them with this set up.

Marking as Passed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-bugs/attachments/20120302/2465f3ed/attachment.htm>