[Koha-bugs] [Bug 6851] A utility that will search out analytics records and set the MARC header appropriately.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6851

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P3
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

--- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
1) General: I agree with Katrin that this script should be handled with care.
In that aspect I would recommend to use some command line option(s) for
actually making the change. Just running without options could print usage
information, just like many other admin scripts do.
As a side-note, I would be interested in a dry run option: How many records
would you change before confirming to change them? (But that could be a
followup, of course.)

2) I can understand that you may want to run this change on your data. But
could the parent not be a collection too, or even an integrating resource (just
mentioning two other possibilities in leader pos 7)? What about pos 19 on the
parent site? As for the child, why per se value c on pos 19? Couldn't it be b
(indep. title)? You don't touch pos 7 on the child, but is it already good?
If you would like this script to be more generic, it should offer probably more
options. If it is so very specific, is that clear enough now? Just asking ;)

3) You use ModBiblioMarc and mention this in a comment. Just glancing through
code, I have the impression that we loose framework on the record. Am I right?

4) Why do you delete the hash key from $ctrl_to_bib in the second while loop?
If you would reach a second child record pointing to that parent, don't you
want to update it as well?

Changing status to reflect the need for at least some answers. Thanks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.