[Koha-bugs] [Bug 7615] Give option to use description for homebranch/holding branch in label creator instead of the branchcode
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Mar 8 16:13:19 CET 2012
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7615
Paul Poulain <paul.poulain at biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |paul.poulain at biblibre.com
--- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
the SQL query was ugly and would have been worth being rewritten:
* we should never return biblioitems.* because there's marcxml that can be
quite large ! (even if it's less true now that items are no more stored here)
* the query should be written SELECT * FROM a LEFT JOIN b USING(somekey) and
not SELECT * FROM a,b WHERE a.key=b.key.
I won't mark failed QA because the query was already like this, but for next
commits, it's worth rewritting the SQL !
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list