[Koha-bugs] [Bug 7031] More options for AdvancedSearchTypes

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7031

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8

--- Comment #24 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:

After applying the 4 patches, I get:
"my" variable $total masks earlier declaration in same scope at
catalogue/search.pl line 706.

that was here before the patch
(perl -wc catalogue/search.pl)

so it's OK

staff-global.css says:
+.adsearch {

isn't there a typo here ? shouldn't it be advsearch  (add a v), as it's
everywhere else ? I've grepped "adsearch", and it appears nowhere except in
staff-global.css, so I think it's a typo.

If you confirm it is, just switch back to "passed QA", i'll do the fix & push
this (great) feature, as everything seems to work well.

Note : I tested with my UNIMARC setup, and everything worked out of the box,
well done !

-- 
You are receiving this mail because:
You are watching all bug changes.