[Koha-bugs] [Bug 7618] HTML special characters break result table and incorrectly show SQL in Run This Report

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to comment #5)
> (In reply to comment #3)
> > I'm not sure that I understand why/how Koha 3.2 wouldn't be supported by the
> > community (am I not a member of the community?), since the branch is still
> > available via the git. 
> > 
> 
> Not supported, maintained. It's still available on git, but has been end of
> lifed. There will be no more 3.2.x releases ever. 
> 
> The 2 stable branches are 3.4.x and 3.6.x .. the current stable releases are
> 3.4.7 and 3.6.4. The last release for 3.2.x was 3.2.11 3 months ago.
> 
> When 3.8.0 is released in april, the 3.4.x branch will be end of lifed also.
> 
> We keep 2 stable branches and 1 development branch running.
> 
> > Also, it appears that you are incorrect about the patch breaking the links
> > in the report. If you look at guided_reports_start.tmpl, you'll see that I'm
> > just escaping the HTML characters in the SQL that is displayed above the
> > results. The HTML in the actual results still works perfectly fine.
> 
> There are no longer any .tmpl files in Koha, since 3.4.0 we switched to
> template toolkit. This is a major reason this patch will not apply for
> master. Patches should be written to be applied to master, then
> cherry-picked by the release maintainer to the appropriate stable branch.
> 
> If this patch was rewritten to apply to the master (development branch) then
> it could be backported to 3.4.x and 3.6.x and be in the next releases of
> those. As well as being in the next feature release 3.8.0.
> 
> Hope this clears it up.

Thanks Jared and Chris. That really does clear things up a lot. 

I've taken a look at the master code, and the fix looks conceptually the same,
despite the change in template management. Should I upload a new patch for the
master branch on this same bug (after changing the version details)?

-- 
You are receiving this mail because:
You are watching all bug changes.