[Koha-bugs] [Bug 7001] User Configurable Slips

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001

--- Comment #100 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Comment on attachment 8196
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8196
Bug 7167 Followup FIX conflicts with Bug 5347

I'm not against the patch, but I have to comment:
* Having to use Encode::encode() is wrong - all content comes from the
database, therefore should be utf8 already. This looks as curing the symptom,
not the cause.
* Even if it needs to be done, I suggest the right place would be where the
$letter is generated.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.