[Koha-bugs] [Bug 5668] Star ratings in the opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

--- Comment #50 from Mason James <mtj at kohaaloha.com> ---
so heres my patch... with all the outstanding issued resolved ;)


1/ Why did you comment some unit tests ? They are ok.
FIXED

2/ You declare OpacStarRatings for template in C4::Auth, but it is only used in
2 tmpl (opac-results.tt and opac-detail.tt). Isn't it better to declare them in
their respective pl file ?
FIXED

3/ Why have you set the POD in the end of the module and not before each
function like (nearly) everywhere in Koha ? (C4::Ratings)
FIXED

4/ There is a TODO in opac/opac-ratings-ajax.pl :) 
FIXED

Moreover, in this script, why the "use warnings" line is commented ?
FIXED

I think the use of C4::Dates can be deleted
FIXED

5/ Why don't you create a foreign key for biblionumber and borrowernumber with
"on delete cascade" in the ratings table ?
FIXED

6/ It appears that a more recent version of jquery.ratings.js exists (v3.13 vs
v3.10) it is certainly not important, but why don't have choose the lastest ? I
don't have checked the difference between both.
FIXED

7/ Some useless comment lines are still present (#use Smart::Comments '####';)
FIXED

8/ As said Katrin, javascript code is generated into a .pl file, isn't it
possible to open an alert into the javascript code ? After returns of ajax
response for example ?
FIXED

A couple of markup issues: 
<input class="auto-submit-star" type="radio"  name="rating[% biblionumber %]" 
value="1" [% IF (rating_val_1) %]checked="1"[% END %] [% IF (rating_readonly)
%]disabled="disabled"[% END %]   />
FIXED

'checked="1"' should be 'checked="checked"', and embedding [% IF %] inside a
tag goes against a coding guideline we have to prevent errors with the
translation script:
FIXED

oleonard at oleonard-desktop:~/kohaclone$ prove xt
# Looks like you failed 1 test of 1.

FIXED
-------------------------------------
mason at xen1:~/g/head$ prove xt
xt/permissions.t .. ok    
xt/tt_valid.t ..... ok   
All tests successful.
Files=2, Tests=27,  3 wallclock secs ( 0.02 usr  0.01 sys +  2.92 cusr  0.03
csys =  2.98 CPU)
Result: PASS  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<
-------------------------------------

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.