[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Mar 19 12:53:13 CET 2012
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310
Ian Walls <koha.sekjal at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #65 from Ian Walls <koha.sekjal at gmail.com> ---
Everything in the core patch looks really good. While the exported subroutines
of C4/VirtualShelves.pm were changed greatly, no hanging calls were left in the
rest of the system. The SQL and logic look clean.
One small thing: C4/Auth.pm removed the export of template param "bartotal",
but this is still used in one template, opac/opac-results.tt, to display a More
Lists option in the dropdown menu. It doesn't appear that this param gets
exported anywhere else, so I believe it will fail to display the More Lists
option at any time. I don't know if this is particularly relevant, and I'm not
sure how best to deal with it, but any fix for this can be handled with a
followup patch.
Marking as Passed QA. Will reattach patches in correct order in a moment
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list