[Koha-bugs] [Bug 5549] Hourly Loans

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5549

Ian Walls <koha.sekjal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #45 from Ian Walls <koha.sekjal at gmail.com> ---
We're getting there!  Found 4 serious problems, 2 warnings and 1 scope issue. 
There is also a followup issue that can be dealt with later or in a separate
bug.  Marking as Failed QA until the issues below are resolved.  But we're
almost there!


Problems:

1. t/db_dependent/rollingloans.t fails on test 1.  Looks like it's trying to
use hard-coded barcodes for patrons and materials that don't necessarily exist.
 This causes an invalid due date to be returned, blowing up the test.  Problem
with the test, not the code.

2. On patron details page, "checked out on" is showing the due datetime, not
the checkout datetime.  The Due column only shows date, not time.  This seems
to be fine on the circulation screen, but not on members/moremember.pl

3. SetVersion removed from updatedatebase.pl version 3.05.00.004.  Also, DB
revs from atomicupdate/issues_datetime.pl are repeated in 3.05.00.020.  Really,
nothing should be in updatedatabase.pl until the RM adds it.

4.  Release notes for 3.4.1 have been inserted... these are wicked out of date
now, and not really appropriate for master anyway.


Potential problems:

1. Seems like some of the work for 7001 is showing up as new to this branch...
could be a rebase issue, but there is a borrower field, suburb, which is
referenced but does not exist.

2. What's up with the .po files here?  Usually they don't get touched during
the addition of a feature.  I think Git learned about these, and now needs to
forget.


Scope issue:

This still has the High Holds development snuck into it.  This is outside the
scope of hourly loans, and should be it's own enhancement.  This project is
already large enough without other, unrelated functionality hitching a ride. 
It needs to be extricated from this branch.



Followup:

RM:  automatically have updatedatabase.pl run the hourlyloans.sql and
issue_datetimes.pl updates to properly set the DB.

Add new dependencies ReadOnly, ReadOnly::XS and DateTime::Format::DateParse to
install_misc/debian.packages and install_misc/ubuntu.packages

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.