[Koha-bugs] [Bug 5596] add author to holds to pull report

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com

--- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #7)
> I agree that I broke the rules in including an additional change, but I
> disagree that extra CPU cycles is a reason why a change like this might be
> rejected. Using GetMarcBiblio is currently the ONLY way we have to get
> subtitle, for better or worse.

Agreeing with Owen and Ian in fact...

My feeling is that an acceptable circumventing would be to memoize the
GetMarcBiblio sub. Once it's done, subsequent calls to the function will cost
nothing (note : I've said memoize, not memoize with memcache, as this 2nd
option will give a longer persistency, but at the -heavy- price of a http call
to memcached)

The best/long term option would be to use a good ORM & internal caching &
things like that, but they are not close.

patch pushed (that removes subtitle, that was already here before the patch))

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.