[Koha-bugs] [Bug 5668] Star ratings in the opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

--- Comment #56 from Mason James <mtj at kohaaloha.com> ---
(In reply to comment #55)
> I've rebased this as part of the QA process, and figured I'd attach it here
> since I'm at a stopping point for the moment.
> 
> This seems to work alright, but t/db_dependent/Ratings.t fails on me.  There
> is a note that it will fail on any database that doesn't have a blank
> 'ratings' table... this seems like a less than useful test to me.  And, it
> failed both with and without lines in the ratings table.
> 
> I'm not sure if this is a problem with the code or the unit test.  Could
> someone take a look before I resume QA?


oops - i was using non-existant borrowers to test (10001, 10002, etc...)

ive corrected the test, which now uses valid 'test_database' borrowers
(102,103)

and i've removed the incorrect "test will fail on any database that doesn't
have a blank 'ratings' table" statement


all ratings tests now pass
------------------------------------------------------
mason at xen1:~/g/head$ perl   t/db_dependent/Ratings.t 
1..12
ok 1 - use C4::Ratings;
ok 2 - add a rating
ok 3 - add another rating
ok 4 - update a rating
ok 5 - get a rating, with borrowernumber
ok 6 - get a rating, without borrowernumber
ok 7 - get a bib's average(float) rating
ok 8 - get a bib's average(int) rating
ok 9 - get a bib's total number of ratings
ok 10 - verify user's bib rating
ok 11 - delete a rating
ok 12 - delete another rating

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.