[Koha-bugs] [Bug 7092] Complete-subfield searches TraceCompleteSubfields syspref not working correctly

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092

--- Comment #17 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
Paul,

(In reply to comment #16)
> (In reply to comment #12)
> > I have also set UseICU = 1 in updatedatabase.pl, since that will preserve
> > the current
> > behaviour of Koha, but UseICU = 0 in sysprefs.sql, since most new
> > installations will
> > not have ICU activated.
> 
> mmm... If I understand correctly, it means that someone not using ICU don't
> has a problem before your patch, and will have after, because the default
> value is 1 ?
> In this case, it's a bad idea : we should have libraries that have a working
> behaviour still working, and those with a buggy behaviour before the patch
> be warned that, if they change the new syspref, it will fix the behaviour
> 
> Please confirm i'm wrong or change the default value ;-)

Not exactly. All existing Koha installations have tracings working as if UseICU
is set to 1. While this may be causing problems that would be solved by
changing UseICU to 0, setting UseICU to 1 will not break any existing
installations that are working, while setting UseICU to 0 might. So the problem
you described with the update breaking working installations is exactly why
updatedatabase needs to set UseICU to 1. ;)

Jared

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.