[Koha-bugs] [Bug 7769] members/pay.pl: $template scoping for plack

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 22 01:57:30 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7769

--- Comment #4 from Ian Walls <koha.sekjal at gmail.com> ---
Okay, this is a very simple change, 2 char for 3, but I need a little more
knowledge before I can QA it.

We're changing 'my' to 'our'.  This increases the scope of the 3 variables,
$template, $loggedinuser and $cookie to be global to the module, which makes
sense.  I *think* we need to do this because several subroutines within
members/pay.pl alter $template, and the way that plack or mod_perl work more
explicit scoping is required.  Is this the case?  Are there any side effects of
changing this scope for a non-persistent setup?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list