[Koha-bugs] [Bug 5668] Star ratings in the opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

--- Comment #59 from Ian Walls <koha.sekjal at gmail.com> ---
Looking good, almost there.

Problems:

Unit tests don't work on other database than the testing db, leading to errors
in auto testing suites.  --- I have a followup patch to fix this, will attach
shortly

Breaks Baker & Taylor on opac-details.tt (easy fix, change
BakerTaylorContenturl to BakerTaylorContentURL)

System preference is classed as "Choice", between 'yes', 'no' and 'details',
but the default value is 0, and the code tests on 1|details.  Need to sort out
this to consistent terms, either all textual (recommended) or all numeric.


Non-problems:

Lots of extra whitespace lines are introduced... no need for them, but no
problem, either.  I'm going on the notion that it's better to avoid unnecessary
changes, even if they're benign.

opac-ratings-ajax.pl references opac-detail.tmpl instead of opac-detail.tt...
no biggie, that happens a lot, but better to clean it up as new code is
created.

COinSinOPACResults gets moved in opac-search.pl... again, unnecessary and
benign, just observing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.