[Koha-bugs] [Bug 7470] Babeltheque - new proposal

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments:

(In reply to comment #9)
> (In reply to comment #7)
> > Firefox <3.6:
> > - Buttons "Internet user Critics" and "Extracts" are not displayed correctly
> > - The block "copy - note - comment" does not show in tab
> It's a bug in koha. A js error occured: "$(".close") is null"
> It's not come from this feature.
> Maybe, if you used FF3.5, you can upgrade your browser :-)

Does the problem exist in OPAC ? Does it mean the block doesn't appear at all
or the display is crapy ? (that may make a difference for deciding to "pass QA"
or not: having a crapy display on old browsers is acceptable. Having no display
isn't)
> > Firefox (tested on 3.5, 3.6 and 11.0):the videos are right justified and
> > does not reframes the size of the window / screen
> 
> It's caused by a css specific in sandboxes. I remove the contain of the
> system preference "opacstylesheet" and the display is good.
OK, then it does not prevent from passing QA
(note: it's not specific to sandbox, but to sandbox database you're choosen:
the sandbox koha code is purely koha-community)

> > - The link in facebook is not created correctly
> > (http://www.facebook.com/cgi-bin/koha/opac-detail.pl?biblionumber=1553 and
> > not "http://mykoha.tld/cgi-bin/koha/opac-detail.pl?biblionumber=1553)
> The system preference "OPACBaseURL" must be filled with the good value
OK,

> > - the window Goole+ closes  (sometimes) immediately
> Whow, it seems the guilty is the Google+ API, I have not the control on this
> behaviour.
could you give more details ?

Other QA comments:
* C4/SocialData.pm is not perlcritic compliant:
Bareword file handle opened at line 72, column 5.  See pages 202,204 of PBP. 
(Severity: 5)
Two-argument "open" used at line 72, column 5.  See page 207 of PBP. 
(Severity: 5)

* patch does not apply anymore, please rebase when fixing the previous comment
(will be a trivial rebase)

* opac.css classes= I don't understand why you've BABELTHEQUE classes in
opac.css & commented. Please add some explanations

otherwise, I think I haven't more QA comments to do.

-- 
You are receiving this mail because:
You are watching all bug changes.