[Koha-bugs] [Bug 6858] Adds staticfines.pl for static fines processing

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6858

--- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
* good test plan in comment 12, thanks

* not PERLCRITIC compliant:
"require" statement with library name as string at line 38, column 12.  Use a
bareword instead.  (Severity: 5)
Bareword file handle opened at line 143, column 1.  See pages 202,204 of PBP. 
(Severity: 5)
Two-argument "open" used at line 143, column 1.  See page 207 of PBP. 
(Severity: 5)

(I think the 1st one can't be avoided, but the 2 others should)

* this script is completely new, and:
  - will have to be documented/advertised
  - can't break anything if not used, so will pass QA once the perlcritic stuff
is OK

* Mathilde, I feel you haven't successfully tested that it work. Am I wrong ?
If i'm not, it mean the patch is not signed off for now

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.