[Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> ---
After investigating & thinking of it again, I reject this patch.

Here is my explanation: The patch add a reservedateiso hash entry, and keep the
reservedate. It means we add some code that may be useless, or will become.
Instead of improving code quality, it lower it.
So, I request
- $needsconfirmation{'resreservedate'} = format_date($res->{'reservedate'});
+ $needsconfirmation{'resreservedate'} = $res->{'reservedate'};

(ie = don't introduce a new variable reservedateiso, and a checking that there
is no side effect)

Note that I think there should not be a lot of side effect, as this sub is used
in circulation only, so the updated patch would probably be safe. (But it has
to be checked, it's just my feeling)

-- 
You are receiving this mail because:
You are watching all bug changes.