[Koha-bugs] [Bug 7470] Babeltheque improvement and social networks links (like, +1, ...)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8336|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 8476
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8476&action=edit
Bug 7470 Babeltheque integration

(In reply to comment #10)
> QA comments:
> Does the problem exist in OPAC ? Does it mean the block doesn't appear at
> all or the display is crapy ? (that may make a difference for deciding to
> "pass QA" or not: having a crapy display on old browsers is acceptable.
> Having no display isn't)

It just breaks the display on the opac detail page. It's a bug in master. But
FF3.5 is out of date.

> > > - the window Goole+ closes  (sometimes) immediately
> > Whow, it seems the guilty is the Google+ API, I have not the control on this
> > behaviour.
> could you give more details ?
No :-/
It's a random behavior and it appears on others sites with the google+ "plugin"

> Other QA comments:
> * C4/SocialData.pm is not perlcritic compliant:
> Bareword file handle opened at line 72, column 5.  See pages 202,204 of PBP.
> (Severity: 5)
> Two-argument "open" used at line 72, column 5.  See page 207 of PBP. 
> (Severity: 5)
Ok done with this patch.

> 
> * patch does not apply anymore, please rebase when fixing the previous
> comment (will be a trivial rebase)
Done

> * opac.css classes= I don't understand why you've BABELTHEQUE classes in
> opac.css & commented. Please add some explanations
If fact, the css code must be filled into the Babeltheque account
configuration. I put it into the koha css for information.

-- 
You are receiving this mail because:
You are watching all bug changes.