[Koha-bugs] [Bug 5668] Star ratings in the opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

--- Comment #63 from Mason James <mtj at kohaaloha.com> ---
(In reply to comment #62)
> > 
> > System preference is classed as "Choice", between 'yes', 'no' and 'details',
> > but the default value is 0, and the code tests on 1|details.  Need to sort
> > out this to consistent terms, either all textual (recommended) or all
> > numeric.
> 
> i'll fix this issue now

hmm, this is almost a wont-fix, for me
agreed, the numeric values idea is bad bad bad

some bug (or designed feature?) in preferences.pl makes it currently impossible
to save the literal strings 'yes' and 'no' to the sys-prefs table

either preferences.pl (or mysql itself?), seems to transform the values 'yes'
and 'no', to 1 or 0 when saving

i think the only work around here, is to use some-other values
(disable|details|all)? rather than (no|details|yes)

thats the best i can do...


ps: its also the reason why the goofy '1|details' syntax was used in the first
place, i had simply forgotten the initial problem

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.