[Koha-bugs] [Bug 7398] Show number of holds on a biblio in the OPAC details

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7398

--- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> ---
Just tested this feature, and found a problem: there are 2 sysprefs related to
displaying the hold counter on OPAC:
OPACShowHoldsCount and OPACDisplayRequestPriority

* 1st of all, it would be better to be consistent on names
* 2nd = if you set OPACDisplayRequestPriority=1 and OPACShowHoldsCount=0 the
display is broken (you get the <th> but not the <td>, so the table is wrong (I
agree it's a strange idea though)
* 3rd = overall, i'm wondering if we really need 2 sysprefs, that does almost
the same thing. Is there a use case where we want to display the number of
requests but not your priority ? I feel it's meaningless = when you put your
request, if you know there are already 5 holds, you'll be the 6th one. So
shouldn't we just have one ? (and, maybe, remove OPACDisplayRequestPriority)

keeping failed QA because of #2
If you agree with #3, #1 becomes useless
If you provide a patch for #3 i'll be pleased, otherwise, i'll be OK to push
this patch without it and open an entry for removal of
OPACDisplayRequestPriority. ( But, of course, I prefer the patch ;-) )

-- 
You are receiving this mail because:
You are watching all bug changes.