[Koha-bugs] [Bug 7178] Improve order item creation

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #28 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Larger patch. Code looks good to me, apart from some remarks below. Has got a
lot of attention in testing providing some more grounds to push it.

check_uniqueness.pl: I do not really object to this code, but this script
contains SQL code and injects CGI params into SQL (now guarded fine by grep,
but what happens later?). Would it be better to call a function in a module and
have your code inspect the CGI params somewhat more explicitly in terms of
maintainability? I am not blocking this, leave it up to RM ;)

About the javascript errors: I am still quite sure that this code produces a
few js errors. (Already when I open form New order from empty record). But I do
not have the time to debug it. If you change part A, part B could start
generating errors now. Programming is fun ;) It does not prevent me from
entering an order. So we could find it later. No reason to block a lot of work
either.

Finally, the discussion on quantity zero and the extra click. Personally I
would not be satisfied with leaving it that way. But perhaps we can still work
on it when it reaches master.

So updating status to Passed QA and give Paul a chance to judge it ...

-- 
You are receiving this mail because:
You are watching all bug changes.