[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #11 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Some QA comments:

Your call to GetBiblioFromItemNumber could have a barcode too. Just mentioning.
Furthermore, it seems that you only need itemtype from biblioitems (twice used
in routine). Getting a hashref for all fields from biblio, biblioitems and
items is relative expensive for that purpose ;) No blocker.

You are checking branch transfer limits without consulting
UseBranchTransferLimits ? It could just be off? Suppose that you had some
limits, but disabled the option later. In that case the check could be
incorrect. Note that it is hypothetical. Also you would not need to call
IsBranchTransferAllowed if $hbr eq $branch. (Although it should not hurt.)

Just a note on variable name: name $branchtransferlimitvalue is somewhat
confusing. No blocker.

In conclusion: patch slightly fails QA now. If you still want to push it
however, please send a followup for remark 2. The other points could be
resolved as well, but are of minor importance.
Note also the earlier comments of several testers. Parking this on Failed QA
for further attention.

-- 
You are receiving this mail because:
You are watching all bug changes.