[Koha-bugs] [Bug 5354] Partial duplication of a subscription

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5354

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #12 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment: Without testing the code itself, looks good. Externally tested by
more than one individual. Few comments:

Name SubscriptionDuplicateDroppedInput confuses me, but no blocker. The
description is clear though.

The pref should be added to sysprefs.sql. (I tend to forget that too.) If Paul
pushes this one, could you add it, Paul?

You separate fields with semicolon. Please note that several new prefs separate
with |. I do not mind, but we should go for consistency (at least try ;) No
blocker, but a followup? 

Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.