[Koha-bugs] [Bug 7470] Babeltheque improvement and social networks links (like, +1, ...)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|koha.sekjal at gmail.com       |m.de.rooy at rijksmuseum.nl

--- Comment #13 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comments: Larger patch. Looks good in general. Controlled by several prefs.
So does not hurt anyone who does not use it. Only miss comments from current
Babeltheque users.


Resolved Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Trailing whitespace at apply.

Double dbrev in updatedatabase: please combine into one. Paul could do that at
pushing time..
As it appears, the backquotes are not liked by PostgreSQL. Not a blocker until
now? Lots of these in updatedatabase..

opac-detail: May need some further design work (followup). Not my specialty. OK

update_data: say "$i data insered or updated"; Where does this output go to?
Note spelling error too ;)

get_report: This seems quite a job. Just curiosity: but how often would you
like to do that in a cron job?

update_social_data.pl: /tmp is probably ok for rights, but could be an issue.
bunzip2 will not be in /bin for every linux distro.

opac-detail.tt: https://apis.google.com/js/plusone.js: Do you need to include
this js if you do not use this feature? Probably not.
<a href="mailto:ADRESSE?subject=TO READ : [% title %]>: Does not look great.

In conclusion:
May need some followups. But have no objection to push it further.

-- 
You are receiving this mail because:
You are watching all bug changes.