[Koha-bugs] [Bug 7729] svc API should allow modification of items

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7729

MJ Ray (software.coop) <mjr at ttllp.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #9 from MJ Ray (software.coop) <mjr at ttllp.co.uk> ---
Pasting the reply that I emailed in and it never appeared:

Could you explain the benefit of using $fullrecord in the foreach
that deletes from $record, please?

My fear is that if future new code between the clone and the delete
extend $fullrecord somehow, then deleting all $fullrecord's fields
from $record could raise an error.

The reason why we readd the item details into $one_item_record is that
tests suggested ModItemFromMarc only accepts records with one item, so
we send it item-containing records one at a time.  It might be more
efficient to delete the just-added item and recycle $one_item_record,
rather than clone the item-less $record each time: I've not tested it
and felt it was probably safest to use a new clone.

Thanks for considering this enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.