[Koha-bugs] [Bug 4032] XSLT systempreference should take a path to file rather than YesNo

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1 - high                   |P3
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
           Hardware|PC                          |All
            Version|rel_3_4                     |master
         QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

--- Comment #39 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Like this patch. Just have the impression that we once had this already?
Anyhow, looks good. Two minor remarks:

Error checking: What happens when GetURI returns undef on a URL? Could you fall
back to default or no xslt view? 
Now you have a perl error: Empty String at /usr/share/koha/testclone/C4/XSLT.pm
line 208
This needs a followup.

You test Biblibre by: SELECT 1 FROM systempreferences WHERE
variable="IntranetXSLTDetailsDisplay"
Just theoretically, but someone else using this local pref could run into
problems.. No blocker.

Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.