[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> ---
My tests show 2 problems:
* when you set the syspref to "allow", the user should be able to choose "next
available" or any item. I can't have the item list appearing !
* when you set the syspref to "force", it seems good, as you get the items list
and no option to say "next available". BUT, you can submit the form without
choosing any item, and in this case, it seems that you've placed a "next
available" hold.

The 3rd option (don't allow) is OK

Overall, it may be easy to fix, but for now it does not work.

PS: anyone who tests and want to switch back to master =
DELETE from systempreferences WHERE variable="OPACItemHolds";
INSERT INTO `systempreferences` (variable,value,explanation,options,type)
VALUES('OPACItemHolds','1','Allow OPAC users to place hold on specific items.
If OFF, users can only request next available copy.','','YesNo');

will revert you to "without 7825 applied"
If you just switch to master branch, things go crazy because the syspref is no
more 0/1

-- 
You are receiving this mail because:
You are watching all bug changes.