[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977

--- Comment #48 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA Comment for Bug 7977: Quote-of-the-day (QOTD) Feature for OPAC

- backquotes exist in sql files (updatedatabase and kohastructure)
- Debug javascript message is commited (console.log)
- +    var sEmptyTable = _('No quotes available. Please use the \"Add Quote\"
button to add a quote.');
Why do you escaped double quote ?
- html comments are commited (+<!--                        <th>Actions</th>-->)
- you use new font family (+    font-family: "Georgia","Palatino","Times New
Roman",sans-serif;). Currently, these fonts are not used in Koha. Isn't it
better to use already used fonts ?
- +        my $like = " id LIKE \"%$filter%\" OR source LIKE \"%$filter%\" OR
text LIKE \"%$filter%\" OR timestamp LIKE \"%$filter%\"";
Why don't you use bind parameters to protect against SQL injection attacks ?

-- 
You are receiving this mail because:
You are watching all bug changes.