[Koha-bugs] [Bug 7846] get_batch_summary reimplements GROUP BY in perl code

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon May 14 02:43:57 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7846

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9175|0                           |1
        is obsolete|                            |

--- Comment #15 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 9545
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9545&action=edit
Bug 7846 - get_batch_summary massive speedup

current code is using DISTINCT and another SQL query which can be replaced with
GROUP BY
for massive speedup. In our case, generating Manage Batches screen DBI time
decreased
from 24.762 s to 0.147 s

Aside from correct usage of relational database, this change also cleans up
code nicely.

This change removed semi-columns from SQL query which broke Manage Patron
batches.

Test scenario:

1. open Manage Batches screen and take note of time needed to generate it
2. apply this patch
3. reload page and check page genration time

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list