[Koha-bugs] [Bug 7722] Insidious problem with searching

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7722

Ian Walls <koha.sekjal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #5 from Ian Walls <koha.sekjal at gmail.com> ---
This is a consequence of bug 6990, which had a long thread and a proposed
solution similar to what you're proposing, Kyle, but no actual follow-up patch
written.

Testing is... tricky.  TransformKohaToMarc isn't used very often.... it's a
called as part of GetMarcItem, and in acqui/addorder.pl.  Testing would involve
editing items, and adding orders.  

That said, I think Kyle's approach is sound.  We're only adding an additional
line that will 'next' us if the count of elements returned in $dtm is zero. 
Adding that check is indeed safe, as there should be never be a circumstance
where NULL $tag or $letter should be okay.

I'm going to sign off on this and pass it through QA, as I'm quite confident
this is a safe and logical addition to the code.

-- 
You are receiving this mail because:
You are watching all bug changes.