[Koha-bugs] [Bug 5742] batch edit patrons

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5742

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #23 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
 * this patch contains also a lot of coding guidelines or PBP fixes, like
  - replacing tabs by spaces
  - avoiding things like "return undef" or my $x if $x eq 'condition';
That's a good thing, but the "usefull" code is harder to spot !

 * Question = why do you define new subs like UpdateBorrowerAttribute, and
don't export them ? I think you should (even if they are not used outside from
the package for now, couldn't they be in the future ?)

 * tiny harmless typo "modifivation" instead of "modification" ;-)

 * modborrowers.pl passes perlcritic

 * the new template is valid

=> just answer my question (with a follow-up if applicable), and it will earn
pass QA !

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.