[Koha-bugs] [Bug 5742] batch edit patrons

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5742

--- Comment #24 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #23)
> QA comment:
>  * this patch contains also a lot of coding guidelines or PBP fixes, like
>   - replacing tabs by spaces
>   - avoiding things like "return undef" or my $x if $x eq 'condition';
> That's a good thing, but the "usefull" code is harder to spot !
> 
>  * Question = why do you define new subs like UpdateBorrowerAttribute, and
> don't export them ? I think you should (even if they are not used outside
> from the package for now, couldn't they be in the future ?)
OK, silly me ! they are.

(note that this patch has been signed off by Mathilde during the hackfest,
through sandboxes, I'll add his signoff on the patch itself, with the one from
Stéphane)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.