[Koha-bugs] [Bug 7175] Improve order receiving page

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon May 21 18:17:15 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7175

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
            Version|master                      |rel_3_10

--- Comment #42 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #41)
> (In reply to comment #38)
> > Could you rebase & resubmit (switch back to signed-off, it's probably an
> > easy rebase)
> 
> It was very easy in fact, I had no conflict... I wonder if you took patches
> in the right order. It must be "Bug 7175: orderreceive.pl cosmetic changes"
> first

That's definetly the cause of my problem = it was not written that the patches
were to be applied in reverse order !

QA comments:
 * the code update a line using format_date (+        date                  =>
format_date($order->{entrydate}),), which is deprecated, but it was here
before, so it's OK
 * perlcritic OK for Acquisition.pm acqui/orderreceive.pl
acqui/finishreceive.pl acqui/orderreceive.pl catalogue/getitem-ajax.pl
cataloguing/additem.pl
 * prove xt/author/translatable-templates.t xt/author/valid-templates.t is OK

passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list