[Koha-bugs] [Bug 7977] Add a "Quote-of-the-day" feature to the OPAC homepage

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7977

Ian Walls <koha.sekjal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #69 from Ian Walls <koha.sekjal at gmail.com> ---
QA comments:

1) Introduces a new system dependency, DateTime::Format::MySQL, which only
seems to be used to format datetimes into ISO for querying the quotes table. 
We already have Koha::DateUtils, which can process a datetime in ISO, or many
other formats, so I'm not seeing the need to add a dependency on
DateTime::Format::MySQL.  Does this module do something more that I'm missing?

2) Also, the varchar(45) on the 'source' for the quote seems a bit short... I
think having this as a 'text' field would provide more flexibility.

3) Minor typo in tools/quotes-upload.tt:  "...you will be promoted to..."
should be "...you will be prompted to..."

4) Link to documentation is hardcoded to 3.8 manual page... should it be this
way?  Won't that require maintenance every release, to keep pointing at the
right version?

5) Hardcoded styling in tools/quotes.tt (the <p> under <h1>QOTD Editor</h1>)

Marking as Failed QA primarily for 1), but 3) and 5) need t be addressed, as
well.  2) and 4) are up for discussion.

I think this would be a prime candidate for a Plugin as per Bug 7804... it
seems like a pretty stand-alone thing, if it's basic requirements are met.  The
only complication I see is getting permissions handled properly, but that's
just a matter of a small database update script, which would need to run anyway
to install the table.

-- 
You are receiving this mail because:
You are watching all bug changes.