[Koha-bugs] [Bug 7757] Edit basket vendor after it has been created

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #12 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #11)
> Created attachment 9588 [details]
> Bug 7757 - Followup - Move IF outside of html tag
> 
> Paul, try with it (I removed tabulation characters)

Not better

I've rewritten the patch

QA comment:
 * patch #2 = tiny patch, necessary, passed QA
 * patch #1 = 
   * improve some code, like 
-my $booksellerid;
-$booksellerid = $input->param('booksellerid');
+my $booksellerid = $input->param('booksellerid');
   * coding guidelines OK
   * I'm not sure 
-       
ModBasketHeader($input->param('basketno'),$input->param('basketname'),$input->param('basketnote'),$input->param('basketbooksellernote'),$input->param('basketcontractnumber'));
+        ModBasketHeader( $input->param('basketno'),
$input->param('basketname'), $input->param('basketnote'),
$input->param('basketbooksellernote'), $input->param('basketcontractnumber') ||
undef, $input->param('basketbooksellerid') );
is the best way to deal with an empty basketcontractnumber (
$input->param('basketcontractnumber') || undef ), but there's nothing about
that in the coding guidelines, so I won't object

passed QA

About parameters: I think we should define a rule for new subs, about how we
pass parameters. I think passing hashes would gracefully solve this kind of
problem. So what about a rule like = identifier/mandatory fields are passed
directly, others are passed through a hash
The ModBasketHeader would then become:
ModBasketHeader($basketno, 
         { basketname => $basketname, 
         basketnote => $basketnote, 
         basketbooksellernote => $basketbooksellernote, 
         basketcontractnumber => basketcontractnumber, 
         basketbooksellerid=> $basketbooksellerid}
);

Kyle, if you agree/like this idea, I can start a discussion on koha-devel !

-- 
You are receiving this mail because:
You are watching all bug changes.