[Koha-bugs] [Bug 8559] conflicting item statuses

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559

--- Comment #19 from Mason James <mtj at kohaaloha.com> ---
(In reply to comment #18)
> (In reply to comment #17)
> > QA comment:
> >  * This patch fails koha-qa.pl, but I don't understand well what it means.
> > Mason, explanation welcomed :
> > * C4/Reserves.pm                         FAIL
> > 	pod                         OK
> > 	forbidden patterns          OK
> > 	valid                       FAIL
> > 		Subroutine RevertWaitingStatus redefined 
> > 	critic                      OK
> 
> hi Paul
> 
> the 'valid FAIL' means Reserves.pm failed a 'perl --warnings $FILE' test
> 
> if we google 'perl warning Subroutine redefined' there are some good
> discussions of this problem
> 
> http://stackoverflow.com/questions/3428264/perl-subroutine-redefined

hmmm, after some more testing, i discover something quite strange...

it seems many/most of the subs() in Reserves.pm have the same error?!
atm, i am not sure what is causing this problem :/


$ perl -w ./C4/Reserves.pm 
Subroutine AddReserve redefined at ./C4/Reserves.pm line 143.
Subroutine GetReservesFromBiblionumber redefined at ./C4/Reserves.pm line 256.
Subroutine GetReservesFromItemnumber redefined at ./C4/Reserves.pm line 337.
Subroutine GetReservesFromBorrowernumber redefined at ./C4/Reserves.pm line
362.
Subroutine CanBookBeReserved redefined at ./C4/Reserves.pm line 394.
Subroutine CanItemBeReserved redefined at ./C4/Reserves.pm line 418.
Subroutine GetReserveCount redefined at ./C4/Reserves.pm line 509.
Subroutine GetOtherReserves redefined at ./C4/Reserves.pm line 533.
Subroutine GetReserveFee redefined at ./C4/Reserves.pm line 583.
Subroutine GetReservesToBranch redefined at ./C4/Reserves.pm line 686.
Subroutine GetReservesForBranch redefined at ./C4/Reserves.pm line 711.
Subroutine GetReserveStatus redefined at ./C4/Reserves.pm line 738.
Subroutine CheckReserves redefined at ./C4/Reserves.pm line 777.
Subroutine CancelExpiredReserves redefined at ./C4/Reserves.pm line 871.
Subroutine AutoUnsuspendReserves redefined at ./C4/Reserves.pm line 914.
Subroutine CancelReserve redefined at ./C4/Reserves.pm line 942.
Subroutine ModReserve redefined at ./C4/Reserves.pm line 1057.
Subroutine ModReserveFill redefined at ./C4/Reserves.pm line 1126.
Subroutine ModReserveStatus redefined at ./C4/Reserves.pm line 1194.
Subroutine ModReserveAffect redefined at ./C4/Reserves.pm line 1224.
Subroutine ModReserveCancelAll redefined at ./C4/Reserves.pm line 1282.
Subroutine ModReserveMinusPriority redefined at ./C4/Reserves.pm line 1304.
Subroutine GetReserveInfo redefined at ./C4/Reserves.pm line 1330.
Subroutine IsAvailableForItemLevelRequest redefined at ./C4/Reserves.pm line
1403.
Subroutine AlterPriority redefined at ./C4/Reserves.pm line 1457.
Subroutine ToggleLowestPriority redefined at ./C4/Reserves.pm line 1493.
Subroutine ToggleSuspend redefined at ./C4/Reserves.pm line 1522.
Subroutine SuspendAll redefined at ./C4/Reserves.pm line 1563.
Subroutine _FixPriority redefined at ./C4/Reserves.pm line 1617.
Subroutine _Findgroupreserve redefined at ./C4/Reserves.pm line 1722.
Subroutine _koha_notify_reserve redefined at ./C4/Reserves.pm line 1831.
Subroutine _ShiftPriorityByDateAndPriority redefined at ./C4/Reserves.pm line
1939.
Subroutine MoveReserve redefined at ./C4/Reserves.pm line 1979.
Subroutine MergeHolds redefined at ./C4/Reserves.pm line 2028.
Subroutine RevertWaitingStatus redefined at ./C4/Reserves.pm line 2078.
Subroutine ReserveSlip redefined at ./C4/Reserves.pm line 2132.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.